Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCTTurboModuleManager | Fix narrowing conversion. #39829

Closed
wants to merge 1 commit into from

Conversation

florihupf
Copy link

Summary: ^title^

Reviewed By: sodastsai

Differential Revision: D49948385

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner fb-exported labels Oct 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

2 similar comments
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

florihupf pushed a commit to florihupf/react-native that referenced this pull request Oct 5, 2023
Summary:

Changelog:
    [iOS][Fixed] - Fixed narrowing conversion compilation error.

Reviewed By: sodastsai

Differential Revision: D49948385
florihupf pushed a commit to florihupf/react-native that referenced this pull request Oct 5, 2023
Summary:

Changelog:
    [iOS][Fixed] - Fixed narrowing conversion compilation error.

Reviewed By: sodastsai

Differential Revision: D49948385
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

florihupf pushed a commit to florihupf/react-native that referenced this pull request Oct 5, 2023
Summary:

Changelog:
    [iOS][Fixed] - Fixed narrowing conversion compilation error.

Reviewed By: sodastsai

Differential Revision: D49948385
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

@analysis-bot
Copy link

analysis-bot commented Oct 5, 2023

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 17,317,605 -3
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 20,685,719 +1
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: ce39931
Branch: main

florihupf pushed a commit to florihupf/react-native that referenced this pull request Oct 5, 2023
Summary:

Changelog:
    [iOS][Fixed] - Fixed narrowing conversion compilation error.

Reviewed By: sodastsai

Differential Revision: D49948385
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

Summary:

Changelog:
    [iOS][Fixed] - Fixed narrowing conversion compilation error.

Reviewed By: sodastsai

Differential Revision: D49948385
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D49948385

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

This pull request was successfully merged by Florian Sauer in ed9931f.

When will my fix make it into a release? | Upcoming Releases

@github-actions github-actions bot added the Merged This PR has been merged. label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Warnings
⚠️ One hour and a half have passed and the E2E jobs haven't finished yet.

Generated by 🚫 dangerJS against 6f9f771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants